On Mon, Apr 15, 2024 at 07:20:49AM +0200, Christophe JAILLET wrote: > Le 12/04/2024 à 20:46, Andy Shevchenko a écrit : ... > > - len = resource_size(iomem); > > - if (len < 0x100) > > - dev_err(dev, "Invalid iomem size!\n"); > > Was this test useful? I'm not sure. ioremap anyway works on page size granularity on many architectures, but even besides that, the check was from day 1 for unknown reasons. Perhaps can be safely removed. > Should it be mentioned in the commit message? Or in a separate patch. I'll think about it. -- With Best Regards, Andy Shevchenko