On Wed, Apr 10, 2024 at 11:06:13PM +0300, Andy Shevchenko wrote: > On Wed, Apr 10, 2024 at 09:16:39PM +0200, Hans de Goede wrote: ... > > + mmc_gpiod_set_cd_config(host->mmc, > > + PIN_CONF_PACKED(PIN_CONFIG_BIAS_PULL_UP, 20000)); > > Just noticed, the PIN_CONF_PACKED() is a helper for pinconf-generic.h. It seems > unusual to use it directly, and AFAIU documentation, it's for static > initialisations, however it's not explicitly said. I stand corrected, it's said just in the comment on top of the macro definition, while I admit there is also 'etc.' whatever it means. > Hence, I suggest to use pinconf_to_config_packed() as others do for > the run-time code. -- With Best Regards, Andy Shevchenko
