On Mon, Apr 8, 2024 at 6:27 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On 4/8/24 5:23 PM, Andy Shevchenko wrote: > > On Sun, Apr 07, 2024 at 10:04:48PM +0200, Hans de Goede wrote: > >> Some mmc host drivers may need to fixup a card-detection GPIO's config > >> to e.g. enable the GPIO controllers builtin pull-up resistor on devices > >> where the firmware description of the GPIO is broken (e.g. GpioInt with > >> PullNone instead of PullUp in ACPI DSDT). > >> > >> Since this is the exception rather then the rule adding a config > >> parameter to mmc_gpiod_request_cd() seems undesirable, so instead > >> add a new mmc_gpiod_set_cd_config() function. This is simply a wrapper > >> to call gpiod_set_config() on the card-detect GPIO acquired through > >> mmc_gpiod_request_cd(). > > > > FWIW, > > Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx> > > for just this patch or for the series ? You have no cover-letter, your choice :-) (yes, for the series, but really it's better to have a even small cover letter, `b4` can use it for good in a few ways, although dunno what MMC maintainers use) > > assuming you considered addressing nit-picks. > > Ack will do. -- With Best Regards, Andy Shevchenko
