Am 29.02.24 um 07:40 schrieb Ping-Ke Shih:
-----Original Message-----
From: Fiona Klute <fiona.klute@xxxxxx>
Sent: Wednesday, February 28, 2024 7:55 AM
To: linux-wireless@xxxxxxxxxxxxxxx; Ping-Ke Shih <pkshih@xxxxxxxxxxx>
Cc: Fiona Klute <fiona.klute@xxxxxx>; kvalo@xxxxxxxxxx; ulf.hansson@xxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx;
pavel@xxxxxx; megi@xxxxxx
Subject: [PATCH v2 0/9] rtw88: Add support for RTL8723CS/RTL8703B
[...]
v2:
* Parse PHY status using struct instead of macros
* Prefer MAC from EFUSE if available, move retrieving MAC from DT to
a separate function
* Tidy up wait for IQK to be done, replace mdelay loop with
read_poll_timeout
* Set dual author for rtw88_8723x
* Add missing "static" to rtw8723x function declarations, fixes
build failure when not built as a module
* Various style fixes
You have some changes by v2, so I think you don't need to take my ack-by for
those patches. Then, it will be easier for me to review patches you have
changed.
Sorry, I thought I was supposed to keep them unless I make larger, not
requested changes.
Anyway, could you point out patches I should pay attention? Or I will review
entire patchset one-by-one.
The bigger changes are all in rtw8703b.h (patch 4; the PHY status struct
instead of macros) and rtw8703b.c (patch 5; PHY status parsing, MAC
address retrieval, and IKQ done wait). The PHY status struct is
basically the same as in the vendor driver, I just resolved some macro
detours for big/little endian detection and spelled out "reserved" in
field names.
Changes in the other patches are minimal: additional MODULE_AUTHOR in
rtw8723x.c, missing "static"s in rtw8723x.c and rtw8723x.h, formatting,
and using rtw_read8_mask in the firmware reset (patch 6).
Best regards,
Fiona
