On Wed, Feb 28, 2024 at 9:36 AM Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: > But passing around is_atomic seems ugly > > And esdhc_mcf_buffer_swap32() doesn't sleep, so there should not > be a problem using kmap_atomic() Aha, I'll send a simple patch just making the iteration atomic so we don't overwork this. > As an aside, gotta wonder why there is not: > > #define SG_MITER_LOCAL_PAGE (1 << 3) /* use kmap_local_page */ That beats me, but Christoph probably has a good answer. Yours, Linus Walleij