Re: [PATCH] mmc: davinci_mmc: Drop dangling variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 15 Feb 2024 at 14:28, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> The sg_miter conversion left a dangling unused variable.
> Drop it.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202402142042.vg0lnLdb-lkp@xxxxxxxxx/
> Fixes: ed01d210fd91 ("mmc: davinci_mmc: Use sg_miter for PIO")
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
>  drivers/mmc/host/davinci_mmc.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c
> index c46577305138..8bd938919687 100644
> --- a/drivers/mmc/host/davinci_mmc.c
> +++ b/drivers/mmc/host/davinci_mmc.c
> @@ -211,7 +211,6 @@ static void davinci_fifo_data_trans(struct mmc_davinci_host *host,
>                                         unsigned int n)
>  {
>         struct sg_mapping_iter *sgm = &host->sg_miter;
> -       size_t sglen;
>         u8 *p;
>         unsigned int i;
>
> @@ -224,7 +223,6 @@ static void davinci_fifo_data_trans(struct mmc_davinci_host *host,
>                 return;
>         }
>         p = sgm->addr;
> -       sglen = sgm->length;
>
>         /* NOTE:  we never transfer more than rw_threshold bytes
>          * to/from the fifo here; there's no I/O overlap.
>
> ---
> base-commit: 26d7d52b6253574d5b6fec16a93e1110d1489cef
> change-id: 20240215-mmc-fix-davinci-bda788e8ee69
>
> Best regards,
> --
> Linus Walleij <linus.walleij@xxxxxxxxxx>
>

Good catch

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>




[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux