[PATCH][next][V2] mmc: wbsd: remove redundant assignment to variable id and id check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The variable id is being initialized with a value that is never
read, it is being re-assigned later on. The initialization is
redundant and can be removed.

As noted by Ulf Hansson the unknown hardware check id != 0xFFFF
is also redundant and can be removed too.

Cleans up clang scan build warning:
drivers/mmc/host/wbsd.c:1287:4: warning: Value stored to 'id'
is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
---
V2: As suggested by Ulf Hansson, also remove the redundant
    hardware check for id != 0xFFFF.
---
 drivers/mmc/host/wbsd.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c
index 001a468bc149..4b32421d9f6d 100644
--- a/drivers/mmc/host/wbsd.c
+++ b/drivers/mmc/host/wbsd.c
@@ -1284,8 +1284,6 @@ static int wbsd_scan(struct wbsd_host *host)
 			continue;
 
 		for (j = 0; j < ARRAY_SIZE(unlock_codes); j++) {
-			id = 0xFFFF;
-
 			host->config = config_ports[i];
 			host->unlock_code = unlock_codes[j];
 
@@ -1306,11 +1304,6 @@ static int wbsd_scan(struct wbsd_host *host)
 					return 0;
 				}
 			}
-
-			if (id != 0xFFFF) {
-				DBG("Unknown hardware (id %x) found at %x\n",
-					id, config_ports[i]);
-			}
 		}
 
 		release_region(config_ports[i], 2);
-- 
2.39.2





[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux