Re: [PATCH 0/9] rtw88: Add support for RTL8723CS/RTL8703B

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 02.02.24 um 14:13 schrieb Dmitry Antipov:
On 2/2/24 15:10, Fiona Klute wrote:

This patch set adds a driver for RTL8723CS, which is used in the
Pinephone and a few other devices. It is a combined wifi/bluetooth
device, the wifi part is called RTL8703B. There is already a mainline
driver for the bluetooth part. RTL8703B is similar to the RTL8723D
chip already supported by rtw88. I've been using the out-of-tree
rtl8723cs driver as reference.

On top of wireless-next (17903a283593), I'm seeing:

drivers/net/wireless/realtek/rtw88/mac.c: In function
'__rtw_download_firmware_legacy':
drivers/net/wireless/realtek/rtw88/mac.c:940:33: error:
'RTW_CHIP_TYPE_8703B' undeclared
(first use in this function); did you mean 'RTW_CHIP_TYPE_8723D'?
   940 |         if (rtwdev->chip->id == RTW_CHIP_TYPE_8703B &&
       |                                 ^~~~~~~~~~~~~~~~~~~
       |                                 RTW_CHIP_TYPE_8723D
drivers/net/wireless/realtek/rtw88/mac.c:940:33: note: each undeclared
identifier is
reported only once for each function it appears in

It seems that 'enum rtw_chip_type' has missing an entry.

That definition should have been added to main.h by patch 3 ("wifi:
rtw88: Add definitions for 8703b chip"). Was there some issue with
applying that one?






[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux