On 04/12/23 12:59:07, Avri Altman wrote: > > > We could carry the patch internally (it seems harmless after all the > > > testing > > > done) but I'd much rather land it upstream if possible. > > Agreed. > Also, I am totally fine, and maybe it's even better, with adding this as a default behavior for all vendors. > I see no point in those tunings while accessing rpmb anyway. > I'll repost then without the quirk. In fact just this morning - I was about to update - I was able to test on an early board revision with a different eMMC module (at the time RPMB wasnt validated) which upon reflashing also exhibited the issue see below: # cat /sys/class/mmc_host/mmc0/mmc0\:0001/csd d02700328f5903ffffffffef86400000 # cat /sys/class/mmc_host/mmc0/mmc0\:0001/name 064GB2 [ 218.759036] sdhci-arasan ff160000.mmc: __mmc_blk_ioctl_cmd: data error -84 E/TC:? 0 E/TC:? 0 TA panicked with code 0xffff0000 E/LD: Status of TA 22250a54-0bf1-48fe-8002-7b20f1c9c9b1 E/LD: arch: aarch64 E/LD: region 0: va 0xc0004000 pa 0x7e200000 size 0x002000 flags rw-s (ldelf) E/LD: region 1: va 0xc0006000 pa 0x7e202000 size 0x008000 flags r-xs (ldelf) E/LD: region 2: va 0xc000e000 pa 0x7e20a000 size 0x001000 flags rw-s (ldelf) E/LD: region 3: va 0xc000f000 pa 0x7e20b000 size 0x004000 flags rw-s (ldelf) E/LD: region 4: va 0xc0013000 pa 0x7e20f000 size 0x001000 flags r--s E/LD: region 5: va 0xc0014000 pa 0x7e22c000 size 0x005000 flags rw-s (stack) E/LD: region 6: va 0xc0019000 pa 0x80dc4e298 size 0x002000 flags rw-- (param) E/LD: region 7: va 0xc001b000 pa 0x80dd1c298 size 0x001000 flags rw-- (param) E/LD: region 8: va 0xc0091000 pa 0x00001000 size 0x014000 flags r-xs [0] E/LD: region 9: va 0xc00a5000 pa 0x00015000 size 0x008000 flags rw-s [0] E/LD: [0] 22250a54-0bf1-48fe-8002-7b20f1c9c9b1 @ 0xc0091000 E/LD: Call stack: E/LD: 0xc0093a14 E/LD: 0xc009131c E/LD: 0xc0094d40 E/LD: 0xc0091624 Read persistent value for bootupgrade_available failed: Exec format error Cant print the environment Error: fiovb_printenv command failed. Exiting. > Thanks, > Avri > > > > > Thanks, > > Avri > > > > > > > > > > > Thanks a lot for fixing this, > > > > Avri > > > > > > thanks everyone for the support. > > > > > > > > > > > (btw - yes - our manufacturer id is 0x45 - it is set differently in > > > > the mmc driver for historic reasons - Thank you for adding this.) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
