On Mon, Oct 23, 2023 at 03:31:24AM +0000, Ricky WU wrote: > > > In order to support new chip rts5264, the definitions of some internal > > > registers and workflow have to be modified. > > > > That is fine, but that should be a single patch, right? > > > > Sorry maybe about misunderstand, The modifications mentioned here, it talk about > some judgment expressions add "PID 5264" to make judgement in rtsx_pcr.c, > so only about 30 line modified in rtsx_pcr.c > > > > Added rts5264.c rts5264.h for independent functions of the new chip rts5264 > > > > And then add new support in a new patch, this is still too big as one > > patch to attempt to review it properly. Would you like to review this > > as-is? > > > > Yes, thank you > Because rts5264.c rts5264.h only for rts5264 (new chip). > The past architecture of this driver was like this, and it will good for us to maintain the driver > different chip maybe has different functions and register definitions we used to separate different .c .h Sorry, I don't think I was clear, this needs to be broken up into smaller pieces to be able for us to review it properly. Please do so and resend a new version of the patch series. thanks, greg k-h
