Re: [PATCH 5/5] mmc-utils: lsmmc: Fix emmc capacity calculation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 26 Sept 2023 at 12:02, Avri Altman <avri.altman@xxxxxxx> wrote:
>
> From: wanggang26 <wanggang26@xxxxxxxxxx>
>
> When the device capacity is larger than 2GB, it shouldn't use c_size but
> instead it follows a different calculation using the SEC_COUNT field of
> the ext-csd[215:212] - see eMMC spec JESD84-B51 paragraph 7.3.12.
>
> This bug was already in lsmmc when it got merged into mmc-utils, hence
> the fixes tag.
>
> Fixes: 4af1749d2350 (mmc-utils: Merge the lsmmc tool into mmc-utils)
> Signed-off-by: wanggang26 <wanggang26@xxxxxxxxxx>

I didn't quite see Gang's "Signed-off-by" at the original patch that
was posted (maybe you discussed offlist). Anyway, just to be sure, I
think we need his confirmation that patch is okay, before I can apply
it.

Gang?

Kind regards
Uffe

> ---
>  lsmmc.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lsmmc.c b/lsmmc.c
> index ef8fab1..b7d1c58 100644
> --- a/lsmmc.c
> +++ b/lsmmc.c
> @@ -1819,6 +1819,9 @@ static void print_mmc_csd_capacity(unsigned int c_size, unsigned int c_size_mult
>         int block_len = 1 << read_bl_len;
>         unsigned long long memory_capacity;
>
> +       if (c_size == 0xfff)
> +               return;
> +
>         printf("\tC_SIZE: 0x%03x\n", c_size);
>         printf("\tC_SIZE_MULT: 0x%01x\n", c_size_mult);
>
> --
> 2.42.0
>



[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux