Re: [PATCH v3] mmc: Add quirk MMC_QUIRK_BROKEN_CACHE_FLUSH for Micron eMMC Q2J54A

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2023-09-22 at 19:01 +0200, Francesco Dolcini wrote:
> > +
> > +                       if (host->card->quirks &
> > MMC_QUIRK_BROKEN_CACHE_FLUSH &&
> > +                           !host->card->written_flag && !ret)
> > +                               host->card->written_flag = true;
> 
> From what I can see this branch is followed for both REQ_OP_READ and
> REQ_OP_WRITE, and I would say we want to set this flag only for
> REQ_OP_WRITE.
> 
> Am I wrong?
> 
> Francesco

you are right, we only care about write, I will update it in the next
version, thanks for your review!

Kind regards,
Bean 




[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux