On Tue, Sep 12, 2023 at 02:12:44AM -0700, Emil Renner Berthing wrote: > William Qiu wrote: > > Due to the change of tuning implementation, it's no longer necessary to > > use the "starfive,sysreg" property in dts, so remove it from required. > > nit: again the device tree should be a description of the hardware, so the > justification here shouldn't be that the Linux driver doesn't use the field, > but that it turns out the registers aren't required for the peripheral to work > properly. Don't respin the series just for this though. > > Reviewed-by: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx> The fact that I can't actually apply this without breaking bisection kinda hints at removing it in this patch is incorrect. > > > Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml b/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml > > index 51e1b04e799f..553a75195c2e 100644 > > --- a/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml > > +++ b/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml > > @@ -55,7 +55,6 @@ required: > > - clocks > > - clock-names > > - interrupts > > - - starfive,sysreg > > > > unevaluatedProperties: false > > > > @@ -73,5 +72,4 @@ examples: > > fifo-depth = <32>; > > fifo-watermark-aligned; > > data-addr = <0>; > > - starfive,sysreg = <&sys_syscon 0x14 0x1a 0x7c000000>; > > }; > > -- > > 2.34.1 > > > > > > _______________________________________________ > > linux-riscv mailing list > > linux-riscv@xxxxxxxxxxxxxxxxxxx > > http://lists.infradead.org/mailman/listinfo/linux-riscv
Attachment:
signature.asc
Description: PGP signature
