On Tue, 15 Aug 2023 at 03:41, Wenchao Chen <wenchao.chen@xxxxxxxxxx> wrote: > > First of all, Unisoc's IC provides cmd delay and read delay to ensure > that the host can get the correct data. However, according to SD Spec, > there is no need to do tuning in high speed mode, but with the > development of chip processes, it is more and more difficult to find > a suitable delay to cover all the chips. Therefore, we need SD high > speed mode online tuning. > > In addition, we added mmc_sd_switch() and mmc_send_status() to the > header file to allow it to be usable by the drive > > Signed-off-by: Wenchao Chen <wenchao.chen@xxxxxxxxxx> > --- > drivers/mmc/core/sd_ops.c | 1 + > drivers/mmc/host/sdhci-sprd.c | 152 ++++++++++++++++++++++++++++++++++ > include/linux/mmc/host.h | 2 + > 3 files changed, 155 insertions(+) > > diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c > index ef8d1dce5af1..a59cd592f06e 100644 > --- a/drivers/mmc/core/sd_ops.c > +++ b/drivers/mmc/core/sd_ops.c > @@ -323,6 +323,7 @@ int mmc_sd_switch(struct mmc_card *card, int mode, int group, > return mmc_send_adtc_data(card, card->host, SD_SWITCH, cmd_args, resp, > 64); > } > +EXPORT_SYMBOL_GPL(mmc_sd_switch); Please move changes in include/linux/mmc/host.h and drivers/mmc/core/sd_ops.c into patch1. When doing that, please update the commit messages too. [...] Other than the above, this looks okay to me! Kind regards Uffe