On Fri, Aug 4, 2023 at 6:10 PM Victor Shih <victorshihgli@xxxxxxxxx> wrote: > > Hi, Ulf > > Excuse me, may I know the patch's status? > > If you already have a closer look at a paragraph in the series, > could you let me know your comments first, let me check it first. > > I look forward to your reply. > > Thanks, Victor Shih > > On Mon, Jul 31, 2023 at 11:29 PM Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote: > > > > On 21/07/23 13:13, Victor Shih wrote: > > > From: Victor Shih <victor.shih@xxxxxxxxxxxxxxxxxxx> > > > > > > Summary > > > ======= > > > These patches[1] support UHS-II and fix GL9755 UHS-II compatibility. > > > > > > About UHS-II, roughly deal with the following three parts: > > > 1) A UHS-II detection and initialization: > > > - Host setup to support UHS-II (Section 3.13.1 Host Controller Setup > > > Sequence[2]). > > > - Detect a UHS-II I/F (Section 3.13.2 Card Interface Detection Sequence > > > [2]). > > > - In step(9) of Section 3.13.2 in [2], UHS-II initialization is include > > > Section 3.13.3 UHS-II Card Initialization and Section 3.13.4 UHS-II > > > Setting Register Setup Sequence. > > > > > > 2) Send Legacy SD command through SD-TRAN > > > - Encapsulated SD packets are defined in SD-TRAN in order to ensure Legacy > > > SD compatibility and preserve Legacy SD infrastructures (Section 7.1.1 > > > Packet Types and Format Overview[3]). > > > - Host issue a UHS-II CCMD packet or a UHS-II DCMD (Section 3.13.5 UHS-II > > > CCMD Packet issuing and Section 3.13.6 UHS-II DCMD Packet issuing[2]). > > > > > > 3) UHS-II Interrupt > > > - Except for UHS-II error interrupts, most interrupts share the original > > > interrupt registers. > > > > > > Patch structure > > > =============== > > > patch#1-#6: for core > > > patch#7-#22: for sdhci > > > patch#23: for GL9755 > > > > > > Changes in v9 (July. 21, 2023) > > > * rebased to the linux-kernel-v6.5.0-rc1 in Ulf Hansson next branch. > > > * according to the comments provided by Adrian Hunter to modify the > > > patches base on the [V8 00/23] Add support UHS-II for GL9755. > > > * Patch#2: move sd_uhs2_operation definition of PatchV8[05/23] > > > to PatchV9[02/23] for avoid compilation errors. > > > move uhs2_control definition of PatchV8[05/23] > > > to PatchV9[02/23] for avoid compilation errors. > > > move mmc_host flags definition of PatchV8[05/23] > > > to PatchV9[02/23] for avoid compilation errors. > > > move mmc_host flags MMC_UHS2_SUPPORT definition of > > > PatchV8[05/23] to PatchV9[02/23] for avoid compilation errors. > > > move mmc_host flags MMC_UHS2_SD_TRAN definition of > > > PatchV8[05/23] to PatchV9[02/23] for avoid compilation errors. > > > * Patch#7: Modify the commit message. > > > * Patch#8: Modify the commit message. > > > * Patch#11: Modify annotations in sdhci_get_vdd_value(). > > > * Patch#14: Simplity the turning_on_clk in sdhci_set_ios(). > > > * Patch#18: Modify the annotations in __sdhci_uhs2_send_command(). > > > * Patch#19: Cancel export state of sdhci_set_mrq_done() function. > > > * Patch#23: Rename gl9755_pre_detect_init() to sdhci_gli_pre_detect_init(). > > > Rename gl9755_uhs2_reset_sd_tran() to > > > sdhci_gli_uhs2_reset_sd_tran(). > > > > > > Reference > > > ========= > > > [1] https://gitlab.com/VictorShih/linux-uhs2.git > > > [2] SD Host Controller Simplified Specification 4.20 > > > [3] UHS-II Simplified Addendum 1.02 > > > [4] https://patchwork.kernel.org/project/linux-mmc/cover/20230621100151.6329-1-victorshihgli@xxxxxxxxx/ > > > > > > ----------------- original cover letter from v8 ----------------- > > > Summary > > > ======= > > > These patches[1] support UHS-II and fix GL9755 UHS-II compatibility. > > > > > > About UHS-II, roughly deal with the following three parts: > > > 1) A UHS-II detection and initialization: > > > - Host setup to support UHS-II (Section 3.13.1 Host Controller Setup > > > Sequence[2]). > > > - Detect a UHS-II I/F (Section 3.13.2 Card Interface Detection Sequence > > > [2]). > > > - In step(9) of Section 3.13.2 in [2], UHS-II initialization is include > > > Section 3.13.3 UHS-II Card Initialization and Section 3.13.4 UHS-II > > > Setting Register Setup Sequence. > > > > > > 2) Send Legacy SD command through SD-TRAN > > > - Encapsulated SD packets are defined in SD-TRAN in order to ensure Legacy > > > SD compatibility and preserve Legacy SD infrastructures (Section 7.1.1 > > > Packet Types and Format Overview[3]). > > > - Host issue a UHS-II CCMD packet or a UHS-II DCMD (Section 3.13.5 UHS-II > > > CCMD Packet issuing and Section 3.13.6 UHS-II DCMD Packet issuing[2]). > > > > > > 3) UHS-II Interrupt > > > - Except for UHS-II error interrupts, most interrupts share the original > > > interrupt registers. > > > > > > Patch structure > > > =============== > > > patch#1-#6: for core > > > patch#7-#22: for sdhci > > > patch#23: for GL9755 > > > > > > Changes in v8 (June. 21, 2023) > > > * rebased to the linux-kernel-v6.4.0-rc6 in Ulf Hansson next branch. > > > * fix most of checkpatch warnings/errors. > > > * according to the comments provided by Adrian Hunter to modify the > > > patches base on the [V7 00/23] Add support UHS-II for GL9755. > > > * Patch#6: Add MMC_UHS2_SUPPORT to be cleared in sd_uhs2_detect(). > > > Modify return value in sd_uhs2_attach(). > > > * Patch#7: Use tabs instead of spaces. > > > * Patch#8: Modify MODULE_LICENSE from "GPL v2" to "GPL". > > > * Patch#10: Adjust the position of matching brackets. > > > * Patch#11: Adjust the position of matching brackets. > > > Add the initial value of the pwr in sdhci_uhs2_set_power(). > > > * Patch#13: Initialization be combined with declaration and realigned > > > in sdhci_calc_timeout_uhs2(). > > > Forward declare struct mmc_command in sdhci_uhs2.h. > > > * Patch#14: Add the judgment formula for MMC_TIMING_SPEED_A_HD, > > > MMC_TIMING_SPEED_B and MMC_TIMING_SPEED_B_HD in > > > __sdhci_uhs2_set_ios(). > > > Add the switch case for MMC_TIMING_SPEED_A_HD, > > > MMC_TIMING_SPEED_B and MMC_TIMING_SPEED_B_HD in > > > sdhci_get_preset_value(). > > > mmc_opt_regulator_set_ocr() to instead of > > > mmc_regulator_set_ocr() in sdhci_uhs2_set_ios(). > > > * Patch#15: usleep_range() to instead of udelay() in > > > sdhci_uhs2_interface_detect(). > > > read_poll_timeout() to instead of read_poll_timeout_atomic() > > > in sdhci_uhs2_interface_detect(). > > > Modify return value in sdhci_uhs2_do_detect_init(). > > > * Patch#16: Remove unnecessary include file. > > > read_poll_timeout() to instead of read_poll_timeout_atomic() > > > in sdhci_uhs2_enable_clk(). > > > Put the comment on the end and put the lines in descending > > > line length in sdhci_uhs2_enable_clk(). > > > Modify return value in sdhci_uhs2_enable_clk(). > > > * Patch#17: Reorder the definitions and lose the parentheses in > > > sdhci_uhs2_set_config(). > > > read_poll_timeout() to instead of read_poll_timeout_atomic() > > > in sdhci_uhs2_check_dormant(). > > > * Patch#18: Adjust the position of matching brackets in > > > sdhci_uhs2_send_command_retry(). > > > Modify CameCase definition in __sdhci_uhs2_finish_command(). > > > Modify error message in __sdhci_uhs2_finish_command(). > > > sdhci_uhs2_send_command_retry() to instead of > > > sdhci_uhs2_send_command() in sdhci_uhs2_request(). > > > Use sdhci_uhs2_mode() to simplify code in > > > sdhci_uhs2_request_atomic(). > > > Add forward declaration for sdhci_send_command(). > > > * Patch#19: Forward declare struct mmc_request in sdhci_uhs2.h. > > > Remove forward declaration of sdhci_send_command(). > > > Use mmc_dev() to simplify code in sdhci_request_done_dma(). > > > * Patch#20: Change return type to void for __sdhci_uhs2_add_host_v4(). > > > Remove unused variables in __sdhci_uhs2_add_host_v4(). > > > * Patch#22: Add config select MMC_SDHCI_UHS2 in Kconfig. > > > * Patch#23: Use sdhci_get_vdd_value() to simplify code in > > > gl9755_set_power(). > > > Use read_poll_timeout_atomic() to simplify code in > > > sdhci_wait_clock_stable(). > > > Use read_poll_timeout_atomic() to simplify code in > > > sdhci_gl9755_reset(). > > > > > > Reference > > > ========= > > > [1] https://gitlab.com/VictorShih/linux-uhs2.git > > > [2] SD Host Controller Simplified Specification 4.20 > > > [3] UHS-II Simplified Addendum 1.02 > > > [4] https://patchwork.kernel.org/project/linux-mmc/cover/20230331105546.13607-1-victor.shih@xxxxxxxxxxxxxxxxxxx/ > > > > > > ----------------- original cover letter from v7 ----------------- > > > Summary > > > ======= > > > These patches[1] support UHS-II and fix GL9755 UHS-II compatibility. > > > > > > About UHS-II, roughly deal with the following three parts: > > > 1) A UHS-II detection and initialization: > > > - Host setup to support UHS-II (Section 3.13.1 Host Controller Setup Sequence > > > [2]). > > > - Detect a UHS-II I/F (Section 3.13.2 Card Interface Detection Sequence[2]). > > > - In step(9) of Section 3.13.2 in [2], UHS-II initialization is include Section > > > 3.13.3 UHS-II Card Initialization and Section 3.13.4 UHS-II Setting Register > > > Setup Sequence. > > > > > > 2) Send Legacy SD command through SD-TRAN > > > - Encapsulated SD packets are defined in SD-TRAN in order to ensure Legacy SD > > > compatibility and preserve Legacy SD infrastructures (Section 7.1.1 Packet > > > Types and Format Overview[3]). > > > - Host issue a UHS-II CCMD packet or a UHS-II DCMD (Section 3.13.5 UHS-II > > > CCMD Packet issuing and Section 3.13.6 UHS-II DCMD Packet issuing[2]). > > > > > > 3) UHS-II Interrupt > > > - Except for UHS-II error interrupts, most interrupts share the original > > > interrupt registers. > > > > > > Patch structure > > > =============== > > > patch#1-#6: for core > > > patch#7-#22: for sdhci > > > patch#23: for GL9755 > > > > For patches 7 - 23: > > > > Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> > > Hi, Adrian For some reason, I will slightly modify 3 patches in V10, please help to review again. PatchV10[11/23]: Move some definitions of PatchV9[05/23] to PatchV10[11/23] PatchV10[18/23]: Use tmode_half_duplex to instead of uhs2_tmode0_flag in sdhci_uhs2_set_transfer_mode(). PatchV10[20/23]: Move some definitions of PatchV9[05/23] to PatchV10[20/23] Thanks, Victor Shih
