On Wed, 9 Aug 2023 at 13:51, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Wed, Aug 09, 2023 at 01:33:51PM +0200, Ulf Hansson wrote: > > On Wed, 9 Aug 2023 at 09:19, Harshit Mogalapalli > > <harshit.m.mogalapalli@xxxxxxxxxx> wrote: > > > > > > The platform_get_irq() function returns negative error codes on failure. > > > > > > Fixes: 4e268fed8b18 ("mmc: Add mmc driver for Sunplus SP7021") > > > Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > Closes: https://lore.kernel.org/all/a3829ed3-d827-4b9d-827e-9cc24a3ec3bc@moroto.mountain/ > > > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx> > > > > Applied for fixes and by adding a stable tag, thanks! > > It's not really a fix. The platform_get_irq() function can't actually > return zero. > > I asked Arnd about this and he said that there were some arches where > zero was a valid IRQ but they're not in the upstream kernel any more and > we're hopefully not going to do that again. Alright, I moved this to the next branch and dropped the fixes and stable tags. Kind regards Uffe