Re: [PATCH v2 05/11] firewall: introduce stm32_firewall framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 7/26/23 12:22, Simon Horman wrote:
On Tue, Jul 25, 2023 at 06:40:58PM +0200, Gatien Chevallier wrote:


diff --git a/drivers/bus/stm32_firewall.c b/drivers/bus/stm32_firewall.c


+int stm32_firewall_controller_register(struct stm32_firewall_controller *firewall_controller)
+	struct stm32_firewall_controller *ctrl;
+	pr_info("Registering %s firewall controller\n", firewall_controller->name);
+	if (!firewall_controller)
+		return -ENODEV;

HI Gatien,

Sorry, one more on this patch, that I missed before sending my previous

firewall_controller is checked for NULL here.
But it is already dereferenced on the line above the check.

Flagged by Smatch.


Indeed, thank you. I will change this for V4

Best regards,

[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux