On 26/07/23 06:59, Yangtao Li wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > Signed-off-by: Yangtao Li <frank.li@xxxxxxxx> I already acked a number of patches: https://lore.kernel.org/linux-mmc/af01d060-dbaa-aa54-8203-3da5fcbc0a79@xxxxxxxxx/ Also there do not seem to be any changelogs? > --- > drivers/mmc/host/sdhci-pic32.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pic32.c b/drivers/mmc/host/sdhci-pic32.c > index 6696b6bdd88e..7a0351a9c74e 100644 > --- a/drivers/mmc/host/sdhci-pic32.c > +++ b/drivers/mmc/host/sdhci-pic32.c > @@ -210,7 +210,7 @@ static int pic32_sdhci_probe(struct platform_device *pdev) > return ret; > } > > -static int pic32_sdhci_remove(struct platform_device *pdev) > +static void pic32_sdhci_remove(struct platform_device *pdev) > { > struct sdhci_host *host = platform_get_drvdata(pdev); > struct pic32_sdhci_priv *sdhci_pdata = sdhci_priv(host); > @@ -221,8 +221,6 @@ static int pic32_sdhci_remove(struct platform_device *pdev) > clk_disable_unprepare(sdhci_pdata->base_clk); > clk_disable_unprepare(sdhci_pdata->sys_clk); > sdhci_pltfm_free(pdev); > - > - return 0; > } > > static const struct of_device_id pic32_sdhci_id_table[] = { > @@ -238,7 +236,7 @@ static struct platform_driver pic32_sdhci_driver = { > .of_match_table = of_match_ptr(pic32_sdhci_id_table), > }, > .probe = pic32_sdhci_probe, > - .remove = pic32_sdhci_remove, > + .remove_new = pic32_sdhci_remove, > }; > > module_platform_driver(pic32_sdhci_driver);
