Hi Yangtao,
thanks,
Acked-by: Angelo Dureghello <angelo.dureghello@xxxxxxxxxxx>
On Thu, Jul 13, 2023 at 10:10 AM Yangtao Li <frank.li@xxxxxxxx> wrote:
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
> ---
> drivers/mmc/host/sdhci-esdhc-mcf.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-mcf.c b/drivers/mmc/host/sdhci-esdhc-mcf.c
> index 05926bf5ecf9..a07f8333cd6b 100644
> --- a/drivers/mmc/host/sdhci-esdhc-mcf.c
> +++ b/drivers/mmc/host/sdhci-esdhc-mcf.c
> @@ -489,7 +489,7 @@ static int sdhci_esdhc_mcf_probe(struct platform_device *pdev)
> return err;
> }
>
> -static int sdhci_esdhc_mcf_remove(struct platform_device *pdev)
> +static void sdhci_esdhc_mcf_remove(struct platform_device *pdev)
> {
> struct sdhci_host *host = platform_get_drvdata(pdev);
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> @@ -502,8 +502,6 @@ static int sdhci_esdhc_mcf_remove(struct platform_device *pdev)
> clk_disable_unprepare(mcf_data->clk_per);
>
> sdhci_pltfm_free(pdev);
> -
> - return 0;
> }
>
> static struct platform_driver sdhci_esdhc_mcf_driver = {
> @@ -512,7 +510,7 @@ static struct platform_driver sdhci_esdhc_mcf_driver = {
> .probe_type = PROBE_PREFER_ASYNCHRONOUS,
> },
> .probe = sdhci_esdhc_mcf_probe,
> - .remove = sdhci_esdhc_mcf_remove,
> + .remove_new = sdhci_esdhc_mcf_remove,
> };
>
> module_platform_driver(sdhci_esdhc_mcf_driver);
> --
> 2.39.0
>
--
Angelo Dureghello
Timesys
e. angelo.dureghello@xxxxxxxxxxx
