On Thu, Jul 13, 2023 at 04:07:15PM +0800, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>
Acked-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx>
> ---
> drivers/mmc/host/cb710-mmc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/cb710-mmc.c b/drivers/mmc/host/cb710-mmc.c
> index 6d623b2681c3..0aec33b88bef 100644
> --- a/drivers/mmc/host/cb710-mmc.c
> +++ b/drivers/mmc/host/cb710-mmc.c
> @@ -745,7 +745,7 @@ static int cb710_mmc_init(struct platform_device *pdev)
> return err;
> }
>
> -static int cb710_mmc_exit(struct platform_device *pdev)
> +static void cb710_mmc_exit(struct platform_device *pdev)
> {
> struct cb710_slot *slot = cb710_pdev_to_slot(pdev);
> struct mmc_host *mmc = cb710_slot_to_mmc(slot);
> @@ -766,13 +766,12 @@ static int cb710_mmc_exit(struct platform_device *pdev)
> tasklet_kill(&reader->finish_req_tasklet);
>
> mmc_free_host(mmc);
> - return 0;
> }
>
> static struct platform_driver cb710_mmc_driver = {
> .driver.name = "cb710-mmc",
> .probe = cb710_mmc_init,
> - .remove = cb710_mmc_exit,
> + .remove_new = cb710_mmc_exit,
> #ifdef CONFIG_PM
> .suspend = cb710_mmc_suspend,
> .resume = cb710_mmc_resume,
> --
> 2.39.0
>
--
Michał Mirosław
