On Tue, 20 Jun 2023 at 12:47, Marek Vasut <marex@xxxxxxx> wrote:
>
> Use the BIT(n) macro instead of (1<<n), no functional change.
> Regex 's@(1 \?<< \?\([0-9A-Z_]\+\))@BIT(\1)' .
>
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
I don't think the benefit of this change is worth it. For example,
it's quite useful to run a git blame to see the history of what has
happened.
So, sorry, but I am not going to pick this up - or any other similar
changes, at least for the core layer.
Kind regards
Uffe
> ---
> Cc: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> Cc: Avri Altman <avri.altman@xxxxxxx>
> Cc: Bo Liu <liubo03@xxxxxxxxxx>
> Cc: Deren Wu <deren.wu@xxxxxxxxxxxx>
> Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> Cc: Pierre Ossman <pierre@xxxxxxxxx>
> Cc: Russell King <linux@xxxxxxxxxxxxxxx>
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Cc: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> Cc: linux-mmc@xxxxxxxxxxxxxxx
> ---
> include/linux/mmc/core.h | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
> index 6efec0b9820c1..23db84630ae8a 100644
> --- a/include/linux/mmc/core.h
> +++ b/include/linux/mmc/core.h
> @@ -26,16 +26,16 @@ enum mmc_blk_status {
> struct mmc_command {
> u32 opcode;
> u32 arg;
> -#define MMC_CMD23_ARG_REL_WR (1 << 31)
> +#define MMC_CMD23_ARG_REL_WR BIT(31)
> #define MMC_CMD23_ARG_PACKED ((0 << 31) | (1 << 30))
> -#define MMC_CMD23_ARG_TAG_REQ (1 << 29)
> +#define MMC_CMD23_ARG_TAG_REQ BIT(29)
> u32 resp[4];
> unsigned int flags; /* expected response type */
> -#define MMC_RSP_PRESENT (1 << 0)
> -#define MMC_RSP_136 (1 << 1) /* 136 bit response */
> -#define MMC_RSP_CRC (1 << 2) /* expect valid crc */
> -#define MMC_RSP_BUSY (1 << 3) /* card may send busy */
> -#define MMC_RSP_OPCODE (1 << 4) /* response contains opcode */
> +#define MMC_RSP_PRESENT BIT(0)
> +#define MMC_RSP_136 BIT(1) /* 136 bit response */
> +#define MMC_RSP_CRC BIT(2) /* expect valid crc */
> +#define MMC_RSP_BUSY BIT(3) /* card may send busy */
> +#define MMC_RSP_OPCODE BIT(4) /* response contains opcode */
>
> #define MMC_CMD_MASK (3 << 5) /* non-SPI command type */
> #define MMC_CMD_AC (0 << 5)
> @@ -43,10 +43,10 @@ struct mmc_command {
> #define MMC_CMD_BC (2 << 5)
> #define MMC_CMD_BCR (3 << 5)
>
> -#define MMC_RSP_SPI_S1 (1 << 7) /* one status byte */
> -#define MMC_RSP_SPI_S2 (1 << 8) /* second byte */
> -#define MMC_RSP_SPI_B4 (1 << 9) /* four data bytes */
> -#define MMC_RSP_SPI_BUSY (1 << 10) /* card may send busy */
> +#define MMC_RSP_SPI_S1 BIT(7) /* one status byte */
> +#define MMC_RSP_SPI_S2 BIT(8) /* second byte */
> +#define MMC_RSP_SPI_B4 BIT(9) /* four data bytes */
> +#define MMC_RSP_SPI_BUSY BIT(10) /* card may send busy */
>
> /*
> * These are the native response types, and correspond to valid bit
> --
> 2.39.2
>
