Hi Konrad, On 5/27/2023 12:47 AM, Konrad Dybcio wrote:
On 10.05.2023 15:41, Sricharan Ramabadhran wrote:Add support for the global clock controller found on IPQ5018 based devices. Co-developed-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> Co-developed-by: Gokul Sriram Palanisamy <quic_gokulsri@xxxxxxxxxxx> Signed-off-by: Gokul Sriram Palanisamy <quic_gokulsri@xxxxxxxxxxx> Signed-off-by: Sricharan Ramabadhran <quic_srichara@xxxxxxxxxxx> --- [v4] Fixed to use ARRAY_SIZE() wherever parent_data was used Changed GPL v2 to GPL as per comments drivers/clk/qcom/Kconfig | 10 +- drivers/clk/qcom/Makefile | 1 + drivers/clk/qcom/gcc-ipq5018.c | 3731 ++++++++++++++++++++++++++++++++ 3 files changed, 3740 insertions(+), 2 deletions(-) create mode 100644 drivers/clk/qcom/gcc-ipq5018.c[...]+struct clk_rcg2 lpass_axim_clk_src = { + .cmd_rcgr = 0x2E028,Please use lowercase hex for non-macro-defines, all throughout the file.
ok. Will fix this in V10.
[...]+static struct clk_rcg2 system_noc_bfdcd_clk_src = {Drop clocks that are managed in RPM, they will conflict.
IPQ5018 does not have RPM. Regards, Sricharan
