RE: [PATCH] mmc-utils: Assert MMC_IOC_MULTI_CMD in compile time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >  {
> >  #ifndef MMC_IOC_MULTI_CMD
> > -       fprintf(stderr, "mmc-utils has been compiled without
> MMC_IOC_MULTI_CMD"
> > -                       " support, needed by FFU.\n");
> > -       exit(1);
> > +#error "mmc-utils needs MMC_IOC_MULTI_CMD support"
> 
> May I suggest that we have one place in the file to deal with this.
> Perhaps put it in the top of the file, immediately after #include"
> section.
> 
> Moreover, the MMC_IOC_MULTI_CMD support was added in v4.4, so adding
> that information as part of the error message would be good too I think.
Done.

Thanks,
Avri

> 
> >  #else
> >         int dev_fd, img_fd;
> >         int sect_done = 0, retry = 3, ret = -EINVAL;
> 
> Kind regards
> Uffe




[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux