Re: [PATCH v2 3/4] dt-bindings: mmc: fsl-imx-esdhc: remove property "fsl,wp-controller"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 23, 2023 at 10:03:08AM +0800, Peng Fan wrote:
> 
> 
> On 5/6/2023 6:59 PM, Krzysztof Kozlowski wrote:
> > Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
> > 
> > 
> > On 06/05/2023 09:40, haibo.chen@xxxxxxx wrote:
> > > From: Haibo Chen <haibo.chen@xxxxxxx>
> > > 
> > > Driver do not use this property, so remove it here.
> > 
> > You still need to expand the commit msg and justify why this property is
> > being removed. "Driver" is vague, as it can be BSD driver which also
> > might use this binding. Instead describe why this property should be
> > removed, so we can understand also ABI implications.
> 
> The better approach would be mark it as deprecated.

Sure, but still need to say why.

Rob



[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux