Wed, May 10, 2023 at 07:11:17PM +0530, Sricharan Ramabadhran kirjoitti:
> Add pinctrl definitions for the TLMM of IPQ5018.
...
> +#define FUNCTION(fname) \
> + [msm_mux_##fname] = { \
> + .name = #fname, \
> + .groups = fname##_groups, \
> + .ngroups = ARRAY_SIZE(fname##_groups), \
> + }
Can you coordinate with Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx> and use
his work [1] which moves the QCom drivers to use struct pingroup and struct
pinfunction?
[1]: https://lore.kernel.org/r/1683718725-14869-1-git-send-email-quic_rohiagar@xxxxxxxxxxx
...
> +static const struct of_device_id ipq5018_pinctrl_of_match[] = {
> + { .compatible = "qcom,ipq5018-tlmm", },
> + { },
No comma for the terminator entry.
> +};
Move MODULE_DEVICE_TABLE() here.
--
With Best Regards,
Andy Shevchenko
