On Mon, May 8, 2023 at 11:28 PM Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > On Mon, May 08, 2023 at 11:23:44PM +0200, Linus Walleij wrote: > > > This needs to be > > > > > > return !gpiod_get_value_raw(ts->gpio_pendown); > > > > There is no such function. The gpio descriptor runpath simply assumes that > > device trees can be trusted. > > Sorry, this was supposed to be gpiod_get_raw_value(): > > https://elixir.bootlin.com/linux/latest/source/drivers/gpio/gpiolib.c#L2854 I missed it, I should have very well understood you meant that one... I just read the file too sloppily. > Yeah, we we can land the DT fixes ahead of the driver change that would > be great. Otherwise we need a temporary application of > gpiod_get_raw_value(). If the patch is fine I will send it to the SoC tree and ask for it to be applied as a fix. Yours, Linus Walleij
