On Thu, Apr 6, 2023 at 11:31 AM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> All variants that have the .busy_detect flags set, need to assign the
> ->busy_complete() callback too.
>
> To me it seems a bit silly, to check for a mandatory callback,
> although if you prefer it, then I suggest we do it during ->probe()
> instead.
Nah I drop it.
It's just a bit redundant, what you say is that instead of
if (host->variant->busy_detect) { ... }
it would suffice to everywhere just check if we have
the callback:
if (host->ops->busy_complete) {...}
and we can drop .busy_detect altogether.
But I can deal with that another time.
Yours,
Linus Walleij
