On Mon, Mar 27, 2023 at 12:27:04PM -0700, Bjorn Andersson wrote: > > That's a valid reason that I was looking for. Wouldn't this be a common > problem, something other parts of the stack would like to avoid? > Or it's just a byte array until we get here? > > > It could be done with unaligned memory accesses, though, if you prefer that: > > > > No need to jump through the hoops, but a comment would have saved > (robbed?) me from wondering. The parameter to qcom_ice_program_key() is 'const u8 crypto_key[]', which has no inherent alignment in the type. It might be that the callers currently only pass 4-byte aligned buffers, but I don't think that should be relied on here. - Eric
