On Thu, 23 Mar 2023 at 16:33, Marc Gonzalez <marc.w.gonzalez@xxxxxxx> wrote: > > On 23/03/2023 13:13, Ulf Hansson wrote: > > > On Tue, 21 Mar 2023 at 19:01, Marc Gonzalez wrote: > > > >> An empty non-removable slot might be the symptom of probing too early. > > > > I took the liberty of adjusting the code and the commit message a bit. > > Please let me know if it doesn't look good to you. > > > > So, applied for next, thanks! > > Thanks for reviewing & merging. > > Can you tell me (for my knowledge) why it's better to check > host->bus_ops than host->card ? It doesn't really matter at this point, but to keep consistency for some other earlier code in mmc_rescan(), I decided to use host->bus_ops instead. > > If the situation should not happen, perhaps we should use pr_warn? Yes, maybe you are right. In principle, I didn't want to use the warning level as I simply didn't know if we would end up spamming the log with lots of prints for various platforms. Perhaps we should change, when we know a bit more? Kind regards Uffe
