On Fri, Mar 17, 2023 at 4:16 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > On Mon, Dec 05, 2022 at 10:53:51AM +0200, Tomer Maimon wrote: > > Add Nuvoton NPCM BMC sdhci-pltfm controller driver. > > > > Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx> > > I still don't see this driver in the upstream kernel, or in linux-next. > > Couple of comments: > > - devm ordering does not really matter here. The devm resource > is the clock, it does not depend on local data, and it will be > released last, so that is ok. Not sure. Strictly speaking this is the problem. If you leave a clock going on in a wrong period of time it (theoretically) might break your hardware once and forever. Similar discussion about power, clock and reset signals has been held for camera sensors. -- With Best Regards, Andy Shevchenko
