On 13/03/2023 13:49, Ulf Hansson wrote:
> On Sat, 11 Mar 2023 at 12:12, Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>>
>> The sdhci_get_compatibility() is not used outside of the unit:
>>
>> drivers/mmc/host/sdhci-pltfm.c:76:6: error: no previous prototype for ‘sdhci_get_compatibility’ [-Werror=missing-prototypes]
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>> drivers/mmc/host/sdhci-pltfm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
>> index 328b132bbe57..245e56324dff 100644
>> --- a/drivers/mmc/host/sdhci-pltfm.c
>> +++ b/drivers/mmc/host/sdhci-pltfm.c
>> @@ -73,7 +73,7 @@ static void sdhci_get_compatibility(struct platform_device *pdev)
>> host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>> }
>> #else
>> -void sdhci_get_compatibility(struct platform_device *pdev) {}
>> +static void sdhci_get_compatibility(struct platform_device *pdev) {}
>> #endif /* CONFIG_OF */
>
> sdhci_get_compatibility() is using OF functions with stubs for !OF.
>
> Perhaps a cleaner option is to drop the #ifdef CONFIG_OF completely
> around sdhci_get_compatibility(), thus we can drop the stub too.
Works, indeed, better idea. I'll send v2.
Best regards,
Krzysztof
