Re: [RFC PATCH] brcmfmac: add 43751 SDIO ids and initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14/03/2023 12:08, Ulf Hansson wrote:

> If the delay is to manage vmmc and vqmmc, which is somewhat part of
> the generic specifications (SD/MMC), then it should be described in
> the host's node.
> 
> A pwrseq is something special, which is also platform and device
> specific (the SDIO device). If the delays correspond to this, it
> should be part of the pwrseq node.

Uffe,

Wouldn't it make sense to warn, when probing for a non-removable card
returns nothing?

Something along these lines (which I can spin into a formal patch)

--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -2257,6 +2257,9 @@ void mmc_rescan(struct work_struct *work)
                        break;
        }
 
+       if (!mmc_card_is_removable(host) && !host->card)
+               dev_warn(mmc_dev(host), "no device found");
+
        /*
         * Ignore the command timeout errors observed during
         * the card init as those are excepted.

Regards




[Index of Archives]     [Linux Memonry Technology]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux