> -----Original Message----- > From: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> > Sent: Tuesday, March 14, 2023 4:08 AM > To: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx; Yan-Hsuan Chuang <tony0620emma@xxxxxxxxx>; Kalle Valo > <kvalo@xxxxxxxxxx>; Ulf Hansson <ulf.hansson@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; Chris Morgan <macroalpha82@xxxxxxxxx>; Nitin Gupta > <nitin.gupta981@xxxxxxxxx>; Neo Jou <neojou@xxxxxxxxx>; Jernej Skrabec <jernej.skrabec@xxxxxxxxx> > Subject: Re: [PATCH v2 RFC 1/9] wifi: rtw88: Clear RTW_FLAG_POWERON early in rtw_mac_power_switch() > > Hello Ping-Ke, > > On Mon, Mar 13, 2023 at 3:29 AM Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: > [...] > > > + if (!pwr_on) > > > + clear_bit(RTW_FLAG_POWERON, rtwdev->flags); > > > + > > > pwr_seq = pwr_on ? chip->pwr_on_seq : chip->pwr_off_seq; > > > ret = rtw_pwr_seq_parser(rtwdev, pwr_seq); > > > if (ret) > > > > This patch changes the behavior if rtw_pwr_seq_parser() returns error while > > doing power-off, but I dig and think further about this case hardware stays in > > abnormal state. I think it would be fine to see this state as POWER_OFF. > > Do you agree this as well? > I agree with you. Also I think I should have made it clearer in the > description of the patch that I'm potentially changing the behavior > (and that this is not an issue in my opinion). > If there's any problem during the power on/off sequence then we can't > be fully sure about the power state. > If you have any suggestions how to improve this then please let me know. > No more suggestion for now. Just apply your thought. Ping-Ke
