Hello Ping-Ke, On Mon, Mar 13, 2023 at 10:05 AM Ping-Ke Shih <pkshih@xxxxxxxxxxx> wrote: [...] > > pwr_seq = pwr_on ? chip->pwr_on_seq : chip->pwr_off_seq; > > ret = rtw_pwr_seq_parser(rtwdev, pwr_seq); > > - if (ret) > > - return ret; > > + > > + if (rtw_hci_type(rtwdev) == RTW_HCI_TYPE_SDIO) > > + rtw_write32(rtwdev, REG_SDIO_HIMR, imr); > > > > if (pwr_on) > > set_bit(RTW_FLAG_POWERON, rtwdev->flags); > > If failed to power on, it still set RTW_FLAG_POWERON. Is it reasonable? That sounds very reasonable to me! > Did you meet real problem here? > > Maybe, here can be > > if (pwr_on && !ret) > set_bit(RTW_FLAG_POWERON, rtwdev->flags); I can't remember any issue that I've seen. I'll verify this at the end of the week (until then I am pretty busy with my daytime job) and then go with your suggestion. Thanks again as always - your feedback is really appreciated! Also thank you for commenting on the other patches. I'll take a closer look at your feedback at the end of the week and send another version of this series. Best regards, Martin
