On 12/03/2023 01:44, Brad Larson wrote: > AMD Pensando Elba ARM 64-bit SoC is integrated with this IP and > explicitly controls byte-lane enables. > > Signed-off-by: Brad Larson <blarson@xxxxxxx> Thank you for your patch. There is something to discuss/improve. > interrupts: > maxItems: 1 > @@ -120,6 +119,27 @@ required: > - interrupts > - clocks > > +allOf: > + - $ref: mmc-controller.yaml > + - if: > + properties: > + compatible: > + contains: > + const: amd,pensando-elba-sd4hc > + then: > + properties: > + reg: > + items: > + - description: Host controller registers > + - description: Elba byte-lane enable register for writes > + required: > + - resets > + else: > + properties: > + resets: false I don't think this passed the tests... You disallow resets for everyone else. Why? Drop this line. > + reg: > + maxItems: 1 > + > unevaluatedProperties: false > > examples: Best regards, Krzysztof
