On 06/03/2023 09:35, Krzysztof Kozlowski wrote: >> On 06/03/2023 05:07, Brad Larson wrote: >>> Support the AMD Pensando SoC Controller which is a SPI connected device >>> providing a miscellaneous set of essential board control/status registers. >>> This device is present in all Pensando SoC based designs. >>> >>> Signed-off-by: Brad Larson <blarson@xxxxxxx> >>> --- >>> >>> v10 changes: >>> - Property renamed to amd,pensando-ctrl >>> - Driver is renamed and moved to soc/drivers/amd affecting binding >>> - Delete cs property, driver handles device node creation from parent num-cs >>> fixing schema reg error in a different way >>> >>> v9 changes: >>> - Instead of four nodes, one per chip-select, a single >>> node is used with reset-cells in the parent. >>> - No MFD API is used anymore in the driver so it made >>> sense to move this to drivers/spi. >>> - This driver is common for all Pensando SoC based designs >>> so changed the name to pensando-sr.c to not make it Elba >>> SoC specific. >>> - Added property cs for the chip-select number which is used >>> by the driver to create /dev/pensr0.<cs> >>> >>> --- >>> .../bindings/soc/amd/amd,pensando-ctrl.yaml | 60 +++++++++++++++++++ >>> 1 file changed, 60 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/soc/amd/amd,pensando-ctrl.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/soc/amd/amd,pensando-ctrl.yaml b/Documentation/devicetree/bindings/soc/amd/amd,pensando-ctrl.yaml >>> new file mode 100644 >>> index 000000000000..36694077b2e6 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/soc/amd/amd,pensando-ctrl.yaml >> >> Your subject suggests this is pensando-elbasr but you write everywhere >> pensando-ctrl. Confusing. Pick one. > > Actually pensando-ctrl is for sure not correct, because it misses the > name of the SoC (you call it everywhere "elba"). The reason I dropped elba as part of the name is this driver and its associated SPI attached device (cpld or fpga depending on the board design) will be used across a series of SoCs starting with Elba. Implying its Elba specific is misleading. Regards, Brad
