On 06/03/2023 8:29, Krzysztof Kozlowski wrote: > On 06/03/2023 05:07, Brad Larson wrote: >> Document the cadence qspi controller compatible for AMD Pensando >> Elba SoC boards. The Elba qspi fifo size is 1024. >> >> Signed-off-by: Brad Larson <blarson@xxxxxxx> >> --- >> >> v10 changes: >> - Fix cdns,fifo-depth, only amd,pensando-elba-qspi is 1024 bytes >> >> v9 changes: >> - Add 1024 to cdns,fifo-depth property to resolve dtbs_check error >> >> --- >> .../bindings/spi/cdns,qspi-nor.yaml | 30 +++++++++++++++++-- >> 1 file changed, 28 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml >> index 5c01db128be0..18e4bc04f091 100644 >> --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml >> +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml >> @@ -20,11 +20,39 @@ allOf: >> required: >> - power-domains >> >> + - if: >> + properties: >> + compatible: >> + enum: >> + - amd,pensando-elba-qspi >> + then: >> + properties: >> + cdns,fifo-depth: >> + enum: [ 128, 256, 1024 ] >> + default: 1024 >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: amd,pensando-elba-qspi > > This does not make any sense. You have two ifs for the same. That's an oops, only this is needed + - if: + properties: + compatible: + contains: + const: amd,pensando-elba-qspi + then: + properties: + cdns,fifo-depth: + enum: [ 128, 256, 1024 ] + default: 1024 + else: + properties: + cdns,fifo-depth: + enum: [ 128, 256 ] + default: 128 Regards, Brad
