On 16/02/2023 11:30, William Qiu wrote: > > > On 2023/2/16 18:23, Krzysztof Kozlowski wrote: >> On 15/02/2023 12:32, William Qiu wrote: >>> Add documentation to describe StarFive System Controller Registers. >>> >>> Signed-off-by: William Qiu <william.qiu@xxxxxxxxxxxxxxxx> >>> --- >> >> Thank you for your patch. There is something to discuss/improve. >> >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - starfive,jh7110-stg-syscon >>> + - starfive,jh7110-sys-syscon >>> + - starfive,jh7110-aon-syscon >> >> Maybe keep them ordered alphabetically? >> > > I'm sorting by register address, or I can keep them ordered > alphabetically，which is better? We don't know register address here, so I propose alphabetically. Best regards, Krzysztof
