On 16.02.2023 10:41, Heiner Kallweit wrote: > On 16.02.2023 10:34, Krzysztof Kozlowski wrote: >> On 16/02/2023 10:29, Heiner Kallweit wrote: >>> On 16.02.2023 10:18, Krzysztof Kozlowski wrote: >>>> On 14/02/2023 22:42, Heiner Kallweit wrote: >>>>> Support passing a second interrupt as card detect interrupt. >>>>> >>>>> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> >>>>> --- >>>>> Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml >>>>> index 46e235bf2..c8c30300d 100644 >>>>> --- a/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml >>>>> +++ b/Documentation/devicetree/bindings/mmc/amlogic,meson-gx-mmc.yaml >>>>> @@ -28,7 +28,7 @@ properties: >>>>> maxItems: 1 >>>>> >>>>> interrupts: >>>>> - maxItems: 1 >>>>> + maxItems: 2 >>>> >>>> Wait, you now *require* (not support) cd interrupt, so this looks like >>>> ABI break. >>>> >>> The second interrupt is optional. If not provided MMC core falls back to >>> cd polling. >> >> It is not. Your binding requires it. Did you test it on DTS without the >> second interrupt? >> > You're right, the binding misses a minItems 1. I'll add that and the > interrupt description. > Ulf, do you require an add-on patch that fixes the binding issue or a replacement patch? >>> >>>> Second, you must describe the items. >>>> >>> OK, this will be added. >> >> >> Best regards, >> Krzysztof >> >
