Re: [PATCH] dt-bindings: mmc: Add resets property to cadence SDHCI binding

[Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>]

Hi Krzysztof,

On 2023/02/09 18:14, Krzysztof Kozlowski wrote:
> On 09/02/2023 02:42, Kunihiko Hayashi wrote:
> > Cadence SDHCI controller allows reset control support on UniPhier SoC.
> > Add resets property to cadence SDHCI binding.
> >
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> > b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> > index d3dce4d6c168..adacd0535c14 100644
> > --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> > @@ -29,6 +29,9 @@ properties:
> >     clocks:
> >       maxItems: 1
> >
> > +  resets:
> > +    maxItems: 1
>
> This looks specific to UniPhier, doesn't it?

I think this IP has some hardware reset lines, however,
it depends on the implementation whether the lines can be
soft controlled or controlled by power-on-reset.

In case of UniPhier SoC, these lines are connected to the syscon
reset controller, but deasserted with initial state.

Currently, the binding has one compatible.
If drawing this dependency, Is the device dependent compatible necessary?
Or I can remove reset property from DT.

Thank you,

---
Best Regards
Kunihiko Hayashi