On Thu, Feb 2, 2023 at 12:10 PM William Qiu <william.qiu@xxxxxxxxxxxxxxxx> wrote: > On 2022/12/9 5:09, Linus Walleij wrote: > >> + priv->syscon_offset = args.args[0]; > >> + priv->syscon_shift = args.args[1]; > >> + priv->syscon_mask = args.args[2]; > > > > Why should these three things be in the device tree instead of being derived > > from the compatible-string or just plain hard-coded as #defines? > > I don't get it. > > > Hi Linus, > > I'm sorry to bother you, but as for the definition of syscon, after discussing with > my colleagues, we think it is easier to distinguish SDIO0 and SDIO1 by defining it in > the device tree, and the code compatibility is better. OK sounds good looking forward to seeing the result :) Yours, Linus Walleij
