On Tue, Jan 31, 2023 at 10:01 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Tue, Jan 31, 2023 at 09:47:42AM +0100, Linus Walleij wrote: > > If we enable the MMC/SD block layer, use Kconfig to imply the BFQ > > I/O scheduler. > > > > As all MMC/SD devices are single-queue, this is the scheduler that > > users want so let's be helpful and make sure it gets > > default-selected into a manual kernel configuration. It will still > > need to be enabled at runtime (usually with udev scripts). > > NAK. Nothing requires a specific scheduler here - the scheduler is a > pure user choice. If MMC required a specific scheduler I would use select IOSCHED_BFQ. Now it doesn't require it, it will just perform better, so thus I use imply IOSCHED_BFQ the point with it is to help users make the right decisions, not enforce them. fs/crypto/Kconfig does the same thing for example, advice not enforce. Yours, Linus Walleij
