On 1/25/2023 4:43 PM, Krzysztof Kozlowski wrote:
On 25/01/2023 11:45, Kathiravan Thirumoorthy wrote:
From: Kathiravan T <quic_kathirav@xxxxxxxxxxx>
Add binding for the Qualcomm IPQ5332 Global Clock Controller.
Signed-off-by: Kathiravan T <quic_kathirav@xxxxxxxxxxx>
---
Thank you for your patch. There is something to discuss/improve.
Thanks for taking time to review the patch.
+ clocks:
+ items:
+ - description: Board XO clock source
+ - description: Sleep clock source
+ - description: PCIE 2lane PHY pipe clock source
+ - description: PCIE 2lane x1 PHY pipe clock source (For second lane)
+ - description: USB PCIE wrapper pipe clock source
+
+ clock-names:
+ items:
+ - const: xo
+ - const: sleep_clk
+ - const: pcie_2lane_phy_pipe_clk
+ - const: pcie_2lane_phy_pipe_clk_x1
+ - const: usb_pcie_wrapper_pipe_clk
+
+required:
+ - compatible
clocks are required
Ack.
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ clock-controller@1800000 {
+ compatible = "qcom,ipq5332-gcc";
+ reg = <0x01800000 0x80000>;
+ #clock-cells = <1>;
+ #power-domain-cells = <1>;
+ #reset-cells = <1>;
+ };
+...
diff --git a/include/dt-bindings/clock/qcom,gcc-ipq5332.h b/include/dt-bindings/clock/qcom,gcc-ipq5332.h
new file mode 100644
index 000000000000..a305c648b724
--- /dev/null
+++ b/include/dt-bindings/clock/qcom,gcc-ipq5332.h
Filename should match bindings/compatible.
Ack.
Best regards,
Krzysztof
Thanks,
Kathiravan T.
