Am Freitag, 20. Januar 2023, 09:57:22 CET schrieb Krzysztof Kozlowski:
> Node names should be generic and should not contain underscores.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml | 2 +-
> Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml | 2 +-
> Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml
> index 911a5996e099..588be73168fa 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-emmc.yaml
> @@ -41,7 +41,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> - sdhci0_pwrseq {
> + pwrseq {
[applicable for all 3 examples]
hmm, power-sequences are not necessarily tied to an address and I guess
it will be very much a common case to have multiple ones on a system.
So might it be better to follow other patterns (like leds) to number them
or suggest a "foo-pwrseq" / "pwrseq-foo"?
Heiko
> compatible = "mmc-pwrseq-emmc";
> reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>;
> };
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml
> index 3397dbff88c2..b35e00e8c65e 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-sd8787.yaml
> @@ -35,7 +35,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> - wifi_pwrseq: wifi_pwrseq {
> + pwrseq {
> compatible = "mmc-pwrseq-sd8787";
> powerdown-gpios = <&twl_gpio 0 GPIO_ACTIVE_LOW>;
> reset-gpios = <&twl_gpio 1 GPIO_ACTIVE_LOW>;
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
> index 64e3644eefeb..00feaafc1063 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.yaml
> @@ -55,7 +55,7 @@ additionalProperties: false
> examples:
> - |
> #include <dt-bindings/gpio/gpio.h>
> - sdhci0_pwrseq {
> + pwrseq {
> compatible = "mmc-pwrseq-simple";
> reset-gpios = <&gpio1 12 GPIO_ACTIVE_LOW>;
> clocks = <&clk_32768_ck>;
>
