On Thu, 1 Dec 2022 at 12:50, <ye.xingchen@xxxxxxxxxx> wrote: > > From: ye xingchen <ye.xingchen@xxxxxxxxxx> > > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. There are plenty of other conversions that can be done using sysfs_emit_at() in drivers/memstick/core/mspro_block.c. Would you mind doing that too, as part of the $subject patch? Kind regards Uffe > > Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx> > --- > drivers/memstick/core/mspro_block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c > index 61cf75d4a01e..ae3a5dc00344 100644 > --- a/drivers/memstick/core/mspro_block.c > +++ b/drivers/memstick/core/mspro_block.c > @@ -356,7 +356,7 @@ static ssize_t mspro_block_attr_show_modelname(struct device *dev, > struct mspro_sys_attr, > dev_attr); > > - return scnprintf(buffer, PAGE_SIZE, "%s", (char *)s_attr->data); > + return sysfs_emit(buffer, "%s\n", (char *)s_attr->data); > } > > static ssize_t mspro_block_attr_show_mbr(struct device *dev, > -- > 2.25.1
