On Wed, 30 Nov 2022 at 13:12, Christoph Niedermaier
<cniedermaier@xxxxxxxxxxxxxxxxxx> wrote:
>
> The current comment on wakeup-source is a little confusing because
> the word deprecated can be interpreted at first glance to mean that
> wakeup-source is deprecated. Also mentioning the obsolete property
> confuses more than it helps. Therefore, the comment should be removed
> completely because the enable-sdio-wakeup property is not used in
> any current DTs. Also remove enable-sdio-wakeup reference in
> wakeup-source.txt
>
> Signed-off-by: Christoph Niedermaier <cniedermaier@xxxxxxxxxxxxxxxxxx>
Applied for next, thanks!
Kind regards
Uffe
> ---
> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: Marek Vasut <marex@xxxxxxx>
> Cc: kernel@xxxxxxxxxxxxxxxxxx
> Cc: linux-mmc@xxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> To: linux-kernel@xxxxxxxxxxxxxxx
> ---
> V2: - Instead of changing the comment, remove it
> V3: - Remove also reference in power/wakeup-source.txt
> ---
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 1 -
> Documentation/devicetree/bindings/power/wakeup-source.txt | 13 ++++++-------
> 2 files changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 802e3ca8be4d..e82c00368088 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -293,7 +293,6 @@ properties:
> description:
> SDIO only. Preserves card power during a suspend/resume cycle.
>
> - # Deprecated: enable-sdio-wakeup
> wakeup-source:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> diff --git a/Documentation/devicetree/bindings/power/wakeup-source.txt b/Documentation/devicetree/bindings/power/wakeup-source.txt
> index cfd74659fbed..697333a56d5e 100644
> --- a/Documentation/devicetree/bindings/power/wakeup-source.txt
> +++ b/Documentation/devicetree/bindings/power/wakeup-source.txt
> @@ -17,15 +17,14 @@ interrupt.
> List of legacy properties and respective binding document
> ---------------------------------------------------------
>
> -1. "enable-sdio-wakeup" Documentation/devicetree/bindings/mmc/mmc.txt
> -2. "gpio-key,wakeup" Documentation/devicetree/bindings/input/gpio-keys{,-polled}.txt
> -3. "has-tpo" Documentation/devicetree/bindings/rtc/rtc-opal.txt
> -4. "linux,wakeup" Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
> +1. "gpio-key,wakeup" Documentation/devicetree/bindings/input/gpio-keys{,-polled}.txt
> +2. "has-tpo" Documentation/devicetree/bindings/rtc/rtc-opal.txt
> +3. "linux,wakeup" Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt
> Documentation/devicetree/bindings/mfd/tc3589x.txt
> Documentation/devicetree/bindings/input/touchscreen/ads7846.txt
> -5. "linux,keypad-wakeup" Documentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt
> -6. "linux,input-wakeup" Documentation/devicetree/bindings/input/samsung-keypad.txt
> -7. "nvidia,wakeup-source" Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt
> +4. "linux,keypad-wakeup" Documentation/devicetree/bindings/input/qcom,pm8xxx-keypad.txt
> +5. "linux,input-wakeup" Documentation/devicetree/bindings/input/samsung-keypad.txt
> +6. "nvidia,wakeup-source" Documentation/devicetree/bindings/input/nvidia,tegra20-kbc.txt
>
> Examples
> --------
> --
> 2.11.0
>
