On 11/29/22 16:30, Ulf Hansson wrote:
On Tue, 29 Nov 2022 at 13:36, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
On 22/11/2022 12:11, Christoph Niedermaier wrote:
The current comment on wakeup-source is a bit confusing, because it isn't
clear at first sight which property is actually deprecated.
Change the comment to one that is less confusing.
It's still confusing - you mention some non-existing property. I don't
think it's worth to touch it. If you insist, drop entire comment...
Hmm, it doesn't look that easy to me. The "enable-sdio-wakeup" is
indeed a deprecated wakeup property [1], but it seems like it's not
really described somewhere. I wouldn't mind removing it (as it seems
to add some confusions), but in that case it needs to be entirely
removed from the DT docs, right?
Another option, would be to add a proper description of the property
and mark it with "deprecated: true".
There are no in-tree DTs which use the property, so maybe we should just
drop it altogether from the bindings ?
next-20221128$ git grep enable-sdio-wakeup
Documentation/devicetree/bindings/mmc/mmc-controller.yaml: #
Deprecated: enable-sdio-wakeup
Documentation/devicetree/bindings/power/wakeup-source.txt:1.
"enable-sdio-wakeup"
Documentation/devicetree/bindings/mmc/mmc.txt
drivers/mmc/core/host.c: device_property_read_bool(dev,
"enable-sdio-wakeup")) /* legacy */
drivers/mmc/host/sdhci-pltfm.c: device_property_read_bool(dev,
"enable-sdio-wakeup")) /* legacy */
