On 29/11/2022 13:06, Ulf Hansson wrote: > On Tue, 22 Nov 2022 at 12:43, Christoph Niedermaier > <cniedermaier@xxxxxxxxxxxxxxxxxx> wrote: >> >> The current comment on wakeup-source is a bit confusing, because it isn't >> clear at first sight which property is actually deprecated. >> Change the comment to one that is less confusing. >> >> Signed-off-by: Christoph Niedermaier <cniedermaier@xxxxxxxxxxxxxxxxxx> >> --- >> Cc: Ulf Hansson <ulf.hansson@xxxxxxxxxx> >> Cc: Rob Herring <robh+dt@xxxxxxxxxx> >> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> >> Cc: Marek Vasut <marex@xxxxxxx> >> Cc: kernel@xxxxxxxxxxxxxxxxxx >> Cc: linux-mmc@xxxxxxxxxxxxxxx >> Cc: devicetree@xxxxxxxxxxxxxxx >> To: linux-kernel@xxxxxxxxxxxxxxx >> --- >> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml >> index 802e3ca8be4d..a921442c6c1d 100644 >> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml >> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml >> @@ -293,7 +293,7 @@ properties: >> description: >> SDIO only. Preserves card power during a suspend/resume cycle. >> >> - # Deprecated: enable-sdio-wakeup >> + # Use wakeup-source instead of the deprecated enable-sdio-wakeup >> wakeup-source: >> $ref: /schemas/types.yaml#/definitions/flag >> description: > > Rob, Krzysztof - do we have a preferred pattern for how to express > deprecated bindings - or is the above okay to you? Yes, we have: deprecated: true I don't get why this is in response to LED patch? I entirely ignored this thread because of it. Best regards, Krzysztof
