On 28/11/2022 03:44, Doug Brown wrote: > Add a compatible for the pxav1 controller in the PXA168, along with > optional pinctrl properties to use for an errata workaround. > > Signed-off-by: Doug Brown <doug@xxxxxxxxxxxxx> > --- > .../devicetree/bindings/mmc/sdhci-pxa.yaml | 22 ++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml > index 1c87f4218e18..e3fb34853921 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml > +++ b/Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml > @@ -4,7 +4,7 @@ > $id: http://devicetree.org/schemas/mmc/sdhci-pxa.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Marvell PXA SDHCI v2/v3 bindings > +title: Marvell PXA SDHCI v1/v2/v3 bindings > > maintainers: > - Ulf Hansson <ulf.hansson@xxxxxxxxxx> > @@ -34,6 +34,7 @@ allOf: > properties: > compatible: > enum: > + - mrvl,pxav1-mmc > - mrvl,pxav2-mmc > - mrvl,pxav3-mmc > - marvell,armada-380-sdhci > @@ -61,6 +62,25 @@ properties: > - const: io > - const: core > > + pinctrl-names: > + description: > + Optional for supporting PXA168 SDIO IRQ errata to switch CMD pin between SDIO CMD and > + GPIO mode. > + minItems: 2 No need for minItems. > + items: > + - const: default > + - const: state_cmd_gpio > + > + pinctrl-0: > + description: > + should contain default pinctrl. Start with capital letter if this is a sentence with full stop. It's anyway looking different then the rest of the file, right? > + maxItems: 1 Why maxItems: 1? What if one wants to add here more entries? Drop maxItems. > + > + pinctrl-1: > + description: > + should switch CMD pin to GPIO mode as a high output. > + maxItems: 1 Ditto > + > mrvl,clk-delay-cycles: > description: Specify a number of cycles to delay for tuning. > $ref: /schemas/types.yaml#/definitions/uint32 Best regards, Krzysztof
