On 2022/11/23 0:29, Ulf Hansson wrote:
On Fri, 18 Nov 2022 at 09:10, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
On Fri, 18 Nov 2022 at 08:54, Yang Yingliang <yangyingliang@xxxxxxxxxx> wrote:
Hi,
On 2022/11/10 10:55, Yang Yingliang wrote:
This patchset fix a refcount leak and two memory leaks about
SDIO function.
v3 -> v4:
Drop patch1, keep calling put_device() to free memory,
set 'func->card' to NULL to avoid redundant put.
v2 -> v3:
Change to call of_node_put() in remove() function to
fix node refcount leak.
v1 -> v2:
Fix compile error in patch #2.
Yang Yingliang (2):
mmc: sdio: fix of node refcount leak in sdio_add_func()
mmc: sdio: fix possible memory leak in some error path
drivers/mmc/core/sdio.c | 1 +
drivers/mmc/core/sdio_bus.c | 6 +++---
drivers/mmc/core/sdio_cis.c | 3 ++-
3 files changed, 6 insertions(+), 4 deletions(-)
Is this look good to you, or any suggestions?
I need some more time to review them, so I will get back to this early
next week.
I have re-started to look into these patches, so I will provide you
with some comments very soon.
Although, may I ask how you have tested these changes? Or are the
changes done from a pure code inspection point of view?
Compiled test only.
Thanks,
Yang
Kind regards
Uffe
.
